Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 272008: Forgot backspace/shift-backspace. (Closed)

Created:
11 years, 2 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Forgot backspace/shift-backspace. This should've been a two-line patch, but due to http://codereview.chromium.org/255028 it became a four-line patch. BUG=12557 TEST=Focus text box on a web page. backspace should delete text. Focus webpage background. backspace/shift-backspace should go history back/forward. When the omnibox is focussed, backspace should delete text, but cmd-1-9 should still switch tabs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28528

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : align #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M chrome/browser/global_keyboard_shortcuts_mac.mm View 1 2 2 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
11 years, 2 months ago (2009-10-09 07:18:06 UTC) #1
jeremy
LGTM http://codereview.chromium.org/272008/diff/1001/2001 File chrome/browser/global_keyboard_shortcuts_mac.mm (right): http://codereview.chromium.org/272008/diff/1001/2001#newcode43 Line 43: {false, false, false, kVK_Delete, IDC_BACK}, columns should ...
11 years, 2 months ago (2009-10-09 07:20:55 UTC) #2
Nico
11 years, 2 months ago (2009-10-09 07:27:38 UTC) #3
Thanks for not sleeping :-)

http://codereview.chromium.org/272008/diff/1001/2001
File chrome/browser/global_keyboard_shortcuts_mac.mm (right):

http://codereview.chromium.org/272008/diff/1001/2001#newcode43
Line 43: {false, false, false, kVK_Delete,        IDC_BACK},
On 2009/10/09 07:20:55, jeremy wrote:
> columns should line up like in the above table (makes things a little easier
to
> read).

Done.

Powered by Google App Engine
This is Rietveld 408576698