Issue 2720007: Enable remoting unittests to run on build bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2720007: Enable remoting unittests to run on build bots (Closed)

Created:
10 years, 6 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, Alexander Potapenko, Alpha Left Google, Sergey Ulanov, Timur Iskhodzhanov, stuartmorgan, dmac, pam+watch_chromium.org, awong, garykac

Visibility:
Public.

Description

Enable remoting unittests to run on build bots Renamed chromoting.gyp to remoting.gyp. Also enabled remoting_unittests to be executed on the build bots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49609

Patch Set 1 #

Patch Set 2 : done again #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -10 lines)			Patch
M	build/all.gyp	View	1	7 chunks	+8 lines, -2 lines	0 comments	Download
M	build/common.gypi	View		3 chunks	+5 lines, -5 lines	1 comment	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	remoting/remoting.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/heapcheck/chrome_tests.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	tools/valgrind/chrome_tests.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	tools/wine_valgrind/chrome_tests.sh	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

10 years, 6 months ago (2010-06-11 20:42:09 UTC) #2

LGTM provided it passes try bots.

http://codereview.chromium.org/2720007/diff/2001/3002
File build/common.gypi (right):

http://codereview.chromium.org/2720007/diff/2001/3002#newcode113
build/common.gypi:113: # Reomoting compilation is enabled by default. Set to 0
to disable.
Typo. Remoting

Expand Messages | Collapse Messages