Issue 27196: Add webkit.gyp:webkit target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27196: Add webkit.gyp:webkit target. (Closed)

Created:
11 years, 9 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Add webkit.gyp:webkit target. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10451

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -22 lines)			Patch
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View	6 chunks	+23 lines, -22 lines	2 comments	Download
M	webkit/webkit.gyp	View	4 chunks	+61 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

TBR (gyp build/build break) The addition was really easy. I've also added a few missing ...

11 years, 9 months ago (2009-02-26 05:20:44 UTC) #1

darin (slow to review)

11 years, 9 months ago (2009-02-26 15:31:29 UTC) #2

LGTM

http://codereview.chromium.org/27196/diff/1/3
File webkit/tools/test_shell/test_shell.gyp (right):

http://codereview.chromium.org/27196/diff/1/3#newcode22
Line 22: '../../webkit.gyp:glue',
perhaps we also need webkit.gyp:webkit here?

http://codereview.chromium.org/27196/diff/1/3#newcode141
Line 141: '../../webkit.gyp:glue',
and here?

Expand Messages | Collapse Messages