Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 27195: Catch webkit.gyp up to Chromium r10396 WebKit r41217. (Closed)

Created:
11 years, 10 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
tony, dglazkov
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Catch webkit.gyp up to Chromium r10396 WebKit r41217. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10448

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M webkit/webkit.gyp View 11 chunks +31 lines, -20 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
See, wasn't that easy? TBR (gyp build, build break)
11 years, 10 months ago (2009-02-26 04:28:42 UTC) #1
dglazkov
It is very, very pretty. LGTM.
11 years, 10 months ago (2009-02-26 04:59:22 UTC) #2
tony
11 years, 10 months ago (2009-02-26 07:11:54 UTC) #3
http://codereview.chromium.org/27195/diff/1/2
File webkit/webkit.gyp (left):

http://codereview.chromium.org/27195/diff/1/2#oldcode679
Line 679: '../third_party/WebKit/WebCore/dom/Worker.idl',
These idl files should have moved into the WebCore/workers/ directory.

Powered by Google App Engine
This is Rietveld 408576698