Issue 27193: Make render_view_context_menu.cc compile on Posix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27193: Make render_view_context_menu.cc compile on Posix. (Closed)

Created:
11 years, 10 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make render_view_context_menu.cc compile on Posix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10474

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -10 lines)			Patch
M	chrome/browser/browser.scons	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.h	View	2 chunks	+14 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	chrome/chrome.xcodeproj/project.pbxproj	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

heh, I had claimed this on the spreadsheet, but I guess you're just makign it ...

11 years, 9 months ago (2009-02-26 16:32:06 UTC) #2

Mark Mentovai

11 years, 9 months ago (2009-02-26 17:19:38 UTC) #4

http://codereview.chromium.org/27193/diff/10/1014
File chrome/chrome.gyp (left):

http://codereview.chromium.org/27193/diff/10/1014#oldcode1174
Line 1174: 'browser/tab_contents/render_view_context_menu.cc',
Thanks for doing this, I really appreciate it!

For the time being, would you mind Ccing me on any review that changes a .gyp
file?  You don't need to wait for an LGTM from me for simple changes like this,
I just want to be aware of what's moving around because I'm still working pretty
heavily on this stuff.

Expand Messages | Collapse Messages