Issue 27192: Make web_drag_source.cc compile on Posix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27192: Make web_drag_source.cc compile on Posix. (Closed)

Created:
11 years, 10 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make web_drag_source.cc compile on Posix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10443

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -19 lines)			Patch
M	chrome/browser/browser.scons	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_drag_source.h	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drag_source.cc	View	2 chunks	+26 lines, -14 lines	0 comments	Download
M	chrome/chrome.xcodeproj/project.pbxproj	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

The code change is fine. However, I think web_drag_source will end up being platform specific. ...

11 years, 10 months ago (2009-02-26 02:42:09 UTC) #3

tony

11 years, 10 months ago (2009-02-26 18:25:27 UTC) #4

After discussion offline, this LGTM.  It's probably not code that we're going to
use on mac/linux, but this gets us compiling more files.

On 2009/02/26 02:42:09, tony wrote:
> The code change is fine.  However, I think web_drag_source will end up being
> platform specific. That is, eventually we'll probably have a
> web_drag_source_win, web_drag_source_linux, web_drag_source_mac (maybe with a
> shared header defining the interface?)
> 
> I'm not really sure since I don't know how d&d will work on linux/mac, but
> that's my guess.

Expand Messages | Collapse Messages