Issue 2719006: Added TPM command to read space permissions, and a correctness test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2719006: Added TPM command to read space permissions, and a correctness test. (Closed)

Created:
10 years, 6 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, gauravsh

CC:
chromium-os-reviews_chromium.org, gauravsh, Luigi Semenzato

Base URL:
ssh://git@chromiumos-git/tpm_lite.git

Visibility:
Public.

Description

Added TPM command to read space permissions, and a correctness test.

Patch Set 1 #

Patch Set 2 : added test which I forgot to include earlier. #

Total comments: 1

Patch Set 3 : Alphabetize. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -5 lines)			Patch
M	src/testsuite/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	src/testsuite/spaceperm.c	View	1 2	1 chunk	+47 lines, -0 lines	0 comments	Download
M	src/tlcl/generator.c	View		4 chunks	+27 lines, -4 lines	0 comments	Download
M	src/tlcl/tlcl.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/tlcl/tlcl.c	View		2 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

Gaurav is more qualified to LGTM this, but a rubber stamp from Randall will be ...

10 years, 6 months ago (2010-06-09 23:59:41 UTC) #1

gauravsh

LGTM but I didn't see the correctness test. Did you forget to add it to ...

10 years, 6 months ago (2010-06-10 13:03:50 UTC) #2

Luigi Semenzato

On 2010/06/10 13:03:50, gauravsh wrote: > LGTM but I didn't see the correctness test. Did ...

10 years, 6 months ago (2010-06-10 15:34:32 UTC) #3

gauravsh

10 years, 6 months ago (2010-06-10 15:41:35 UTC) #4

lgtm

http://codereview.chromium.org/2719006/diff/4001/5002
File src/testsuite/spaceperm.c (right):

http://codereview.chromium.org/2719006/diff/4001/5002#newcode10
src/testsuite/spaceperm.c:10: #include <stdio.h>
nit: alpha order ;)

Expand Messages | Collapse Messages