Issue 2718014: Windows: Remove invalid gyp settings....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2718014: Windows: Remove invalid gyp settings.... (Closed)

Created:
10 years, 6 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Windows: Remove invalid gyp settings. BUG=45067 TEST=gyp r827 works on Windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49713

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	breakpad/breakpad_handler.gypi	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	breakpad/breakpad_sender.gypi	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

Are you sure about this? I thought we were using urlmon here?

10 years, 6 months ago (2010-06-12 02:20:56 UTC) #2

Lei Zhang

On 2010/06/12 02:20:56, bradn wrote: > Are you sure about this? I thought we were ...

10 years, 6 months ago (2010-06-14 18:24:18 UTC) #3

bradn

10 years, 6 months ago (2010-06-14 18:26:54 UTC) #4

Ah, I think you're right.
Though I believe the link time dependency is real (though probably handled
explicitly or some such.
Maybe migrate it back to each target?
Nah. less is more.
LGTM

Expand Messages | Collapse Messages