Linux: enable compiling GNOME Keyring and KWallet integration. It's still unused.

Linux: enable compiling GNOME Keyring and KWallet integration. It's still unused.
BUG=12351, 25404
TEST=GNOME Keyring and KWallet get compiled, but add no new library dependencies


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49135

[Evan Martin, 2010-06-07 22:46:28]

LGTM

so happy you're doing this!

[tmadeira, 2010-06-08 02:54:34]

Chromium is not compiling here anymore because I don't have gnome-keyring. Is
that the expected behavior?

Updating projects from gyp files...
Package gnome-keyring-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gnome-keyring-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gnome-keyring-1' found
Traceback (most recent call last):
  File "build/gyp_chromium", line 97, in <module>
    sys.exit(gyp.main(args))
  File "./tools/gyp/pylib/gyp/__init__.py", line 445, in main
    options.circular_check)
  File "./tools/gyp/pylib/gyp/__init__.py", line 84, in Load
    depth, generator_input_info, check, circular_check)
  File "./tools/gyp/pylib/gyp/input.py", line 2125, in Load
    depth, check)
  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
    includes, depth, check)
  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
    includes, depth, check)
  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
    includes, depth, check)
  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
    includes, depth, check)
  File "./tools/gyp/pylib/gyp/input.py", line 366, in LoadTargetBuildFile
    build_file_path)
  File "./tools/gyp/pylib/gyp/input.py", line 953, in
ProcessVariablesAndConditionsInDict
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 968, in
ProcessVariablesAndConditionsInList
    ProcessVariablesAndConditionsInDict(item, is_late, variables, build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 946, in
ProcessVariablesAndConditionsInDict
    build_file, key)
  File "./tools/gyp/pylib/gyp/input.py", line 953, in
ProcessVariablesAndConditionsInDict
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 972, in
ProcessVariablesAndConditionsInList
    expanded = ExpandVariables(item, is_late, variables, build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 639, in ExpandVariables
    (contents, p.returncode))
Exception: Call to 'pkg-config --cflags gnome-keyring-1' returned exit status 1.
while loading dependencies of base/base.gyp while loading dependencies of
net/net.gyp while loading dependencies of app/app.gyp while loading dependencies
of build/all.gyp while trying to load build/all.gyp

[Mike Mammarella, 2010-06-08 03:06:00]

Yes, you need to install libgnome-keyring-dev to compile now. (I sent
a message to chromium-dev about it earlier.)

You won't actually need it to run, just to compile.

On Mon, Jun 7, 2010 at 7:54 PM,  <tmadeira@gmail.com> wrote:
> Chromium is not compiling here anymore because I don't have gnome-keyring.
> Is
> that the expected behavior?
>
> Updating projects from gyp files...
> Package gnome-keyring-1 was not found in the pkg-config search path.
> Perhaps you should add the directory containing `gnome-keyring-1.pc'
> to the PKG_CONFIG_PATH environment variable
> No package 'gnome-keyring-1' found
> Traceback (most recent call last):
>  File "build/gyp_chromium", line 97, in <module>
>    sys.exit(gyp.main(args))
>  File "./tools/gyp/pylib/gyp/__init__.py", line 445, in main
>    options.circular_check)
>  File "./tools/gyp/pylib/gyp/__init__.py", line 84, in Load
>    depth, generator_input_info, check, circular_check)
>  File "./tools/gyp/pylib/gyp/input.py", line 2125, in Load
>    depth, check)
>  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
>    includes, depth, check)
>  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
>    includes, depth, check)
>  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
>    includes, depth, check)
>  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
>    includes, depth, check)
>  File "./tools/gyp/pylib/gyp/input.py", line 366, in LoadTargetBuildFile
>    build_file_path)
>  File "./tools/gyp/pylib/gyp/input.py", line 953, in
> ProcessVariablesAndConditionsInDict
>    build_file)
>  File "./tools/gyp/pylib/gyp/input.py", line 968, in
> ProcessVariablesAndConditionsInList
>    ProcessVariablesAndConditionsInDict(item, is_late, variables, build_file)
>  File "./tools/gyp/pylib/gyp/input.py", line 946, in
> ProcessVariablesAndConditionsInDict
>    build_file, key)
>  File "./tools/gyp/pylib/gyp/input.py", line 953, in
> ProcessVariablesAndConditionsInDict
>    build_file)
>  File "./tools/gyp/pylib/gyp/input.py", line 972, in
> ProcessVariablesAndConditionsInList
>    expanded = ExpandVariables(item, is_late, variables, build_file)
>  File "./tools/gyp/pylib/gyp/input.py", line 639, in ExpandVariables
>    (contents, p.returncode))
> Exception: Call to 'pkg-config --cflags gnome-keyring-1' returned exit
> status 1.
> while loading dependencies of base/base.gyp while loading dependencies of
> net/net.gyp while loading dependencies of app/app.gyp while loading
> dependencies
> of build/all.gyp while trying to load build/all.gyp
>
>
> http://codereview.chromium.org/2718001/show
>

[Evan Martin, 2010-06-08 12:43:14]

Aw dang, I was gonna tell you to update the install docs (on the wiki)
as well as install-build-deps.sh but I had thought we'd be ok.  In
retrospect I don't know why I thought that.  Can you update those?  :)

On Mon, Jun 7, 2010 at 8:05 PM, Mike Mammarella <mdm@chromium.org> wrote:
> Yes, you need to install libgnome-keyring-dev to compile now. (I sent
> a message to chromium-dev about it earlier.)
>
> You won't actually need it to run, just to compile.
>
> On Mon, Jun 7, 2010 at 7:54 PM,  <tmadeira@gmail.com> wrote:
>> Chromium is not compiling here anymore because I don't have gnome-keyring.
>> Is
>> that the expected behavior?
>>
>> Updating projects from gyp files...
>> Package gnome-keyring-1 was not found in the pkg-config search path.
>> Perhaps you should add the directory containing `gnome-keyring-1.pc'
>> to the PKG_CONFIG_PATH environment variable
>> No package 'gnome-keyring-1' found
>> Traceback (most recent call last):
>>  File "build/gyp_chromium", line 97, in <module>
>>    sys.exit(gyp.main(args))
>>  File "./tools/gyp/pylib/gyp/__init__.py", line 445, in main
>>    options.circular_check)
>>  File "./tools/gyp/pylib/gyp/__init__.py", line 84, in Load
>>    depth, generator_input_info, check, circular_check)
>>  File "./tools/gyp/pylib/gyp/input.py", line 2125, in Load
>>    depth, check)
>>  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
>>    includes, depth, check)
>>  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
>>    includes, depth, check)
>>  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
>>    includes, depth, check)
>>  File "./tools/gyp/pylib/gyp/input.py", line 408, in LoadTargetBuildFile
>>    includes, depth, check)
>>  File "./tools/gyp/pylib/gyp/input.py", line 366, in LoadTargetBuildFile
>>    build_file_path)
>>  File "./tools/gyp/pylib/gyp/input.py", line 953, in
>> ProcessVariablesAndConditionsInDict
>>    build_file)
>>  File "./tools/gyp/pylib/gyp/input.py", line 968, in
>> ProcessVariablesAndConditionsInList
>>    ProcessVariablesAndConditionsInDict(item, is_late, variables, build_file)
>>  File "./tools/gyp/pylib/gyp/input.py", line 946, in
>> ProcessVariablesAndConditionsInDict
>>    build_file, key)
>>  File "./tools/gyp/pylib/gyp/input.py", line 953, in
>> ProcessVariablesAndConditionsInDict
>>    build_file)
>>  File "./tools/gyp/pylib/gyp/input.py", line 972, in
>> ProcessVariablesAndConditionsInList
>>    expanded = ExpandVariables(item, is_late, variables, build_file)
>>  File "./tools/gyp/pylib/gyp/input.py", line 639, in ExpandVariables
>>    (contents, p.returncode))
>> Exception: Call to 'pkg-config --cflags gnome-keyring-1' returned exit
>> status 1.
>> while loading dependencies of base/base.gyp while loading dependencies of
>> net/net.gyp while loading dependencies of app/app.gyp while loading
>> dependencies
>> of build/all.gyp while trying to load build/all.gyp
>>
>>
>> http://codereview.chromium.org/2718001/show
>>
>

[Mike Mammarella, 2010-06-08 21:02:20]

On 2010/06/08 12:43:14, Evan Martin wrote:
> Aw dang, I was gonna tell you to update the install docs (on the wiki)
> as well as install-build-deps.sh but I had thought we'd be ok.  In
> retrospect I don't know why I thought that.  Can you update those?  :)

Done.