Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2718001: Linux: enable compiling GNOME Keyring and KWallet integration. It's still unused. (Closed)

Created:
10 years, 6 months ago by Mike Mammarella
Modified:
9 years, 7 months ago
Reviewers:
tmadeira, Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: enable compiling GNOME Keyring and KWallet integration. It's still unused. BUG=12351, 25404 TEST=GNOME Keyring and KWallet get compiled, but add no new library dependencies Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -46 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +49 lines, -37 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike Mammarella
10 years, 6 months ago (2010-06-07 22:44:22 UTC) #1
Evan Martin
LGTM so happy you're doing this!
10 years, 6 months ago (2010-06-07 22:46:28 UTC) #2
tmadeira
Chromium is not compiling here anymore because I don't have gnome-keyring. Is that the expected ...
10 years, 6 months ago (2010-06-08 02:54:34 UTC) #3
Mike Mammarella
Yes, you need to install libgnome-keyring-dev to compile now. (I sent a message to chromium-dev ...
10 years, 6 months ago (2010-06-08 03:06:00 UTC) #4
Evan Martin
Aw dang, I was gonna tell you to update the install docs (on the wiki) ...
10 years, 6 months ago (2010-06-08 12:43:14 UTC) #5
Mike Mammarella
10 years, 6 months ago (2010-06-08 21:02:20 UTC) #6
On 2010/06/08 12:43:14, Evan Martin wrote:
> Aw dang, I was gonna tell you to update the install docs (on the wiki)
> as well as install-build-deps.sh but I had thought we'd be ok.  In
> retrospect I don't know why I thought that.  Can you update those?  :)

Done.

Powered by Google App Engine
This is Rietveld 408576698