Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 27175: Fix toolbar keyboard focus (shift-alt-t), which was broken by me, and toolbar... (Closed)

Created:
11 years, 10 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix toolbar keyboard focus (shift-alt-t), which was broken by me, and toolbar button context menus on VK_APPS, which was broken by Jonas. The overall focus issue was caused by my change that made View::RequestFocus() sanity-check that the View was focusable. The toolbar uses a crazy hack where it purposefully wants to get focus even though it's not focusable. :P The context menu issue was caused by Jonas changing the name of a virtual function, presumably not realizing it was a virtual, not just a simple accessor. I changed the name back and marked this function (and several others) as virtual. In order to avoid blowing up the source in toolbar_view.cc, I reverted users of the accessor to just using the member variable name. Also reordered a couple functions to match the order they were originally declared in View.h. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -30 lines) Patch
M chrome/browser/views/frame/browser_view.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/views/toolbar_view.h View 1 chunk +8 lines, -10 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 6 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years, 10 months ago (2009-02-25 22:54:22 UTC) #1
Jonas Klink (Google)
11 years, 9 months ago (2009-02-26 23:56:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698