Gtk: Side tabs for content settings window.

Gtk: Side tabs for content settings window.

UI leads-approved.

BUG=45546
TEST=Open content settings window. Tabs are now on the left.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49467

[Nico, 2010-06-10 22:14:14]

Tell me about spacing.

[Nico, 2010-06-10 22:19:08]

On 2010/06/10 22:14:14, Nico wrote:
> Tell me about spacing.

Screenshot at http://imgur.com/U9Nlw

[Evan Martin, 2010-06-10 22:22:21]

Actually, that looks pretty good to me now that I measure it.  I guess the tab
content feels cramped just because of the side tabs.  You might consider putting
" " on either side of the tab titles to make those a bit wider.

[Evan Martin, 2010-06-10 22:22:37]

+the ui crew

[Nico, 2010-06-10 22:44:18]

Added padding spaces: http://imgur.com/I0ucd

[Evan Martin, 2010-06-10 22:45:48]

LGTM

http://codereview.chromium.org/2717007/diff/6001/7001
File chrome/browser/gtk/options/content_settings_window_gtk.cc (right):

http://codereview.chromium.org/2717007/diff/6001/7001#newcode109
chrome/browser/gtk/options/content_settings_window_gtk.cc:109: gtk_label_new(("
" + label + " ").c_str()));
Can you add a comment near here saying that the extra spacing is due to the tabs
being on the side?

[Nico, 2010-06-10 22:48:37]

Thanks!

http://codereview.chromium.org/2717007/diff/6001/7001
File chrome/browser/gtk/options/content_settings_window_gtk.cc (right):

http://codereview.chromium.org/2717007/diff/6001/7001#newcode109
chrome/browser/gtk/options/content_settings_window_gtk.cc:109: gtk_label_new(("
" + label + " ").c_str()));
On 2010/06/10 22:45:48, Evan Martin wrote:
> Can you add a comment near here saying that the extra spacing is due to the
tabs
> being on the side?

Done.