Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 27169: Linux: add splash screen (Closed)

Created:
11 years, 9 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: add splash screen In preparation for an internal release, add a splash screen with a few important FAQs. Additionally: * Fix GTK reference counting when switching tab contents * Fix double navigation when starting a new tab contents type * Fix bug where BackingStores could have references to removed X windows.

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : ... #

Patch Set 4 : ... #

Patch Set 5 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -27 lines) Patch
M chrome/browser/browser.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/browser_about_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 4 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_view_gtk.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/gtk/tab_contents_container_gtk.cc View 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/backing_store.h View 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_x.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 2 3 2 chunks +6 lines, -5 lines 0 comments Download
A chrome/browser/resources/linux-splash.html View 1 chunk +75 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_factory.cc View 1 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_view_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/x11_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/x11_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
agl
11 years, 9 months ago (2009-02-25 22:23:39 UTC) #1
Evan Martin
looks fine
11 years, 9 months ago (2009-02-25 22:27:13 UTC) #2
agl
11 years, 9 months ago (2009-02-26 02:00:34 UTC) #3
Evan Martin
11 years, 9 months ago (2009-02-26 02:08:53 UTC) #4
OK with ifdefs so we don't have it on windows

Powered by Google App Engine
This is Rietveld 408576698