Issue 2716002: Add a command line switch to enable the pepper testing interface. This moves ...

Issue 2716002: Add a command line switch to enable the pepper testing interface. This moves ... (Closed)

Created:
10 years, 6 months ago by brettw

Modified:
9 years, 3 months ago

Reviewers:
darin (slow to review), Nico

CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a command line switch to enable the pepper testing interface. This moves the other switch we were using in the plugins directory to the new file as well. TEST=covered by UI test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49269

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -4 lines)			Patch
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_module.cc	View		2 chunks	+9 lines, -2 lines	2 comments	Download
M	webkit/glue/plugins/plugin_list_posix.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
A	webkit/glue/plugins/plugin_switches.h	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/plugin_switches.cc	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/2716002/diff/15001/webkit/glue/plugins/pepper_plugin_module.cc File webkit/glue/plugins/pepper_plugin_module.cc (right): http://codereview.chromium.org/2716002/diff/15001/webkit/glue/plugins/pepper_plugin_module.cc#newcode135 webkit/glue/plugins/pepper_plugin_module.cc:135: if (CommandLine::ForCurrentProcess()->HasSwitch("enable-pepper-testing")) Why not kEnablePepperTesting? (Asking because I was ...

9 years, 3 months ago (2011-08-30 20:22:23 UTC) #3

brettw

9 years, 3 months ago (2011-08-30 23:10:41 UTC) #4

http://codereview.chromium.org/2716002/diff/15001/webkit/glue/plugins/pepper_...
File webkit/glue/plugins/pepper_plugin_module.cc (right):

http://codereview.chromium.org/2716002/diff/15001/webkit/glue/plugins/pepper_...
webkit/glue/plugins/pepper_plugin_module.cc:135: if
(CommandLine::ForCurrentProcess()->HasSwitch("enable-pepper-testing"))
I think at the time of this patch there was no shared place for switches for
this code. I added one a while ago so I should be able to convert this over now.

Expand Messages | Collapse Messages