Follow on to r1368: Remove unnecessary HandleScope in the StubCompilers.

src/stub-cache-arm.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 448 matching lines @@
 
 #define __ masm()->
 
 
 Object* StubCompiler::CompileLazyCompile(Code::Flags flags) {
   // ----------- S t a t e -------------
   //  -- r1: function
   //  -- lr: return address
   // -----------------------------------
 
-  HandleScope scope;
-
   // Enter an internal frame.
   __ EnterInternalFrame();
 
   // Preserve the function.
   __ push(r1);
 
   // Push the function on the stack as the argument to the runtime function.
   __ push(r1);
   __ CallRuntime(Runtime::kLazyCompile, 1);
 
@@ skipping 12 matching lines @@
   return GetCodeWithFlags(flags);
 }
 
 
 Object* CallStubCompiler::CompileCallField(Object* object,
                                            JSObject* holder,
                                            int index) {
   // ----------- S t a t e -------------
   //  -- lr: return address
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   const int argc = arguments().immediate();
 
   // Get the receiver of the function from the stack into r0.
   __ ldr(r0, MemOperand(sp, argc * kPointerSize));
   // Check that the receiver isn't a smi.
   __ tst(r0, Operand(kSmiTagMask));
   __ b(eq, &miss);
 
@@ skipping 31 matching lines @@
 }
 
 
 Object* CallStubCompiler::CompileCallConstant(Object* object,
                                               JSObject* holder,
                                               JSFunction* function,
                                               CheckType check) {
   // ----------- S t a t e -------------
   //  -- lr: return address
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   // Get the receiver from the stack
   const int argc = arguments().immediate();
   __ ldr(r1, MemOperand(sp, argc * kPointerSize));
 
   // Check that the receiver isn't a smi.
   if (check != NUMBER_CHECK) {
     __ tst(r1, Operand(kSmiTagMask));
     __ b(eq, &miss);
@@ skipping 100 matching lines @@
   return GetCode(CONSTANT_FUNCTION);
 }
 
 
 Object* CallStubCompiler::CompileCallInterceptor(Object* object,
                                                  JSObject* holder,
                                                  String* name) {
   // ----------- S t a t e -------------
   //  -- lr: return address
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   // TODO(1224669): Implement.
 
   // Handle call cache miss.
   __ bind(&miss);
   Handle<Code> ic = ComputeCallMiss(arguments().immediate());
   __ Jump(ic, RelocInfo::CODE_TARGET);
 
   // Return the generated code.
   return GetCode(INTERCEPTOR);
 }
 
 
 Object* StoreStubCompiler::CompileStoreField(JSObject* object,
                                              int index,
                                              Map* transition,
                                              String* name) {
   // ----------- S t a t e -------------
   //  -- r0    : value
   //  -- r2    : name
   //  -- lr    : return address
   //  -- [sp]  : receiver
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   // Get the receiver from the stack.
   __ ldr(r3, MemOperand(sp, 0 * kPointerSize));
 
   // name register might be clobbered.
   GenerateStoreField(masm(),
                      Builtins::StoreIC_ExtendStorage,
                      object,
                      index,
@@ skipping 12 matching lines @@
 
 Object* StoreStubCompiler::CompileStoreCallback(JSObject* object,
                                                 AccessorInfo* callback,
                                                 String* name) {
   // ----------- S t a t e -------------
   //  -- r0    : value
   //  -- r2    : name
   //  -- lr    : return address
   //  -- [sp]  : receiver
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   // Get the object from the stack.
   __ ldr(r3, MemOperand(sp, 0 * kPointerSize));
 
   // Check that the object isn't a smi.
   __ tst(r3, Operand(kSmiTagMask));
   __ b(eq, &miss);
 
   // Check that the map of the object hasn't changed.
@@ skipping 34 matching lines @@
 
 
 Object* StoreStubCompiler::CompileStoreInterceptor(JSObject* receiver,
                                                    String* name) {
   // ----------- S t a t e -------------
   //  -- r0    : value
   //  -- r2    : name
   //  -- lr    : return address
   //  -- [sp]  : receiver
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   // Get the object from the stack.
   __ ldr(r3, MemOperand(sp, 0 * kPointerSize));
 
   // Check that the object isn't a smi.
   __ tst(r3, Operand(kSmiTagMask));
   __ b(eq, &miss);
 
   // Check that the map of the object hasn't changed.
@@ skipping 32 matching lines @@
 
 
 Object* LoadStubCompiler::CompileLoadField(JSObject* object,
                                            JSObject* holder,
                                            int index) {
   // ----------- S t a t e -------------
   //  -- r2    : name
   //  -- lr    : return address
   //  -- [sp]  : receiver
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   __ ldr(r0, MemOperand(sp, 0));
 
   GenerateLoadField(masm(), object, holder, r0, r3, r1, index, &miss);
   __ bind(&miss);
   GenerateLoadMiss(masm(), Code::LOAD_IC);
 
   // Return the generated code.
   return GetCode(FIELD);
 }
 
 
 Object* LoadStubCompiler::CompileLoadCallback(JSObject* object,
                                               JSObject* holder,
                                               AccessorInfo* callback) {
   // ----------- S t a t e -------------
   //  -- r2    : name
   //  -- lr    : return address
   //  -- [sp]  : receiver
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   __ ldr(r0, MemOperand(sp, 0));
   GenerateLoadCallback(masm(), object, holder, r0, r2, r3, r1, callback, &miss);
   __ bind(&miss);
   GenerateLoadMiss(masm(), Code::LOAD_IC);
 
   // Return the generated code.
   return GetCode(CALLBACKS);
 }
 
 
 Object* LoadStubCompiler::CompileLoadConstant(JSObject* object,
                                               JSObject* holder,
                                               Object* value) {
   // ----------- S t a t e -------------
   //  -- r2    : name
   //  -- lr    : return address
   //  -- [sp] : receiver
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   __ ldr(r0, MemOperand(sp, 0));
 
   GenerateLoadConstant(masm(), object, holder, r0, r3, r1, value, &miss);
   __ bind(&miss);
   GenerateLoadMiss(masm(), Code::LOAD_IC);
 
   // Return the generated code.
   return GetCode(CONSTANT_FUNCTION);
 }
 
 
 Object* LoadStubCompiler::CompileLoadInterceptor(JSObject* object,
                                                  JSObject* holder,
                                                  String* name) {
   // ----------- S t a t e -------------
   //  -- r2    : name
   //  -- lr    : return address
   //  -- [sp]  : receiver
   // -----------------------------------
-
-  HandleScope scope;
   Label miss;
 
   __ ldr(r0, MemOperand(sp, 0));
 
   GenerateLoadInterceptor(masm(), object, holder, r0, r2, r3, r1, &miss);
   __ bind(&miss);
   GenerateLoadMiss(masm(), Code::LOAD_IC);
 
   // Return the generated code.
   return GetCode(INTERCEPTOR);
 }
 
 
 // TODO(1224671): IC stubs for keyed loads have not been implemented
 // for ARM.
 Object* KeyedLoadStubCompiler::CompileLoadField(String* name,
                                                 JSObject* receiver,
                                                 JSObject* holder,
                                                 int index) {
   // ----------- S t a t e -------------
   //  -- lr    : return address
   //  -- sp[0] : key
   //  -- sp[4] : receiver
   // -----------------------------------
-  HandleScope scope;
   Label miss;
 
   __ ldr(r2, MemOperand(sp, 0));
   __ ldr(r0, MemOperand(sp, kPointerSize));
 
   __ cmp(r2, Operand(Handle<String>(name)));
   __ b(ne, &miss);
 
   GenerateLoadField(masm(), receiver, holder, r0, r3, r1, index, &miss);
   __ bind(&miss);
   GenerateLoadMiss(masm(), Code::KEYED_LOAD_IC);
 
   return GetCode(FIELD);
 }
 
 
 Object* KeyedLoadStubCompiler::CompileLoadCallback(String* name,
                                                    JSObject* receiver,
                                                    JSObject* holder,
                                                    AccessorInfo* callback) {
   // ----------- S t a t e -------------
   //  -- lr    : return address
   //  -- sp[0] : key
   //  -- sp[4] : receiver
   // -----------------------------------
-  HandleScope scope;
   Label miss;
 
   __ ldr(r2, MemOperand(sp, 0));
   __ ldr(r0, MemOperand(sp, kPointerSize));
 
   __ cmp(r2, Operand(Handle<String>(name)));
   __ b(ne, &miss);
 
   GenerateLoadCallback(masm(), receiver, holder, r0, r2, r3,
                        r1, callback, &miss);
   __ bind(&miss);
   GenerateLoadMiss(masm(), Code::KEYED_LOAD_IC);
 
   return GetCode(CALLBACKS);
 }
 
 
 Object* KeyedLoadStubCompiler::CompileLoadConstant(String* name,
                                                    JSObject* receiver,
                                                    JSObject* holder,
                                                    Object* value) {
   // ----------- S t a t e -------------
   //  -- lr    : return address
   //  -- sp[0] : key
   //  -- sp[4] : receiver
   // -----------------------------------
-  HandleScope scope;
   Label miss;
 
   // Check the key is the cached one
   __ ldr(r2, MemOperand(sp, 0));
   __ ldr(r0, MemOperand(sp, kPointerSize));
 
   __ cmp(r2, Operand(Handle<String>(name)));
   __ b(ne, &miss);
 
   GenerateLoadConstant(masm(), receiver, holder, r0, r3, r1, value, &miss);
   __ bind(&miss);
   GenerateLoadMiss(masm(), Code::KEYED_LOAD_IC);
 
   // Return the generated code.
   return GetCode(CONSTANT_FUNCTION);
 }
 
 
 Object* KeyedLoadStubCompiler::CompileLoadInterceptor(JSObject* receiver,
                                                       JSObject* holder,
                                                       String* name) {
   // ----------- S t a t e -------------
   //  -- lr    : return address
   //  -- sp[0] : key
   //  -- sp[4] : receiver
   // -----------------------------------
-  HandleScope scope;
   Label miss;
 
   // Check the key is the cached one
   __ ldr(r2, MemOperand(sp, 0));
   __ ldr(r0, MemOperand(sp, kPointerSize));
 
   __ cmp(r2, Operand(Handle<String>(name)));
   __ b(ne, &miss);
 
   GenerateLoadInterceptor(masm(), receiver, holder, r0, r2, r3, r1, &miss);
   __ bind(&miss);
   GenerateLoadMiss(masm(), Code::KEYED_LOAD_IC);
 
   return GetCode(INTERCEPTOR);
 }
 
 
 Object* KeyedLoadStubCompiler::CompileLoadArrayLength(String* name) {
   // ----------- S t a t e -------------
   //  -- lr    : return address
   //  -- sp[0] : key
   //  -- sp[4] : receiver
   // -----------------------------------
-  HandleScope scope;
   Label miss;
 
   // Check the key is the cached one
   __ ldr(r2, MemOperand(sp, 0));
   __ ldr(r0, MemOperand(sp, kPointerSize));
 
   __ cmp(r2, Operand(Handle<String>(name)));
   __ b(ne, &miss);
 
   GenerateLoadArrayLength(masm(), r0, r3, &miss);
   __ bind(&miss);
   GenerateLoadMiss(masm(), Code::KEYED_LOAD_IC);
 
   return GetCode(CALLBACKS);
 }
 
 
 Object* KeyedLoadStubCompiler::CompileLoadStringLength(String* name) {
   // ----------- S t a t e -------------
   //  -- lr    : return address
   //  -- sp[0] : key
   //  -- sp[4] : receiver
   // -----------------------------------
-  HandleScope scope;
-
   Label miss;
   __ IncrementCounter(&Counters::keyed_load_string_length, 1, r1, r3);
 
   __ ldr(r2, MemOperand(sp));
   __ ldr(r0, MemOperand(sp, kPointerSize));  // receiver
 
   __ cmp(r2, Operand(Handle<String>(name)));
   __ b(ne, &miss);
 
   GenerateLoadStringLength2(masm(), r0, r1, r3, &miss);
   __ bind(&miss);
   __ DecrementCounter(&Counters::keyed_load_string_length, 1, r1, r3);
 
   GenerateLoadMiss(masm(), Code::KEYED_LOAD_IC);
 
   return GetCode(CALLBACKS);
 }
 
 
 // TODO(1224671): implement the fast case.
 Object* KeyedLoadStubCompiler::CompileLoadFunctionPrototype(String* name) {
   // ----------- S t a t e -------------
   //  -- lr    : return address
   //  -- sp[0] : key
   //  -- sp[4] : receiver
   // -----------------------------------
-  HandleScope scope;
   GenerateLoadMiss(masm(), Code::KEYED_LOAD_IC);
 
   return GetCode(CALLBACKS);
 }
 
 
 Object* KeyedStoreStubCompiler::CompileStoreField(JSObject* object,
                                                   int index,
                                                   Map* transition,
                                                   String* name) {
   // ----------- S t a t e -------------
   //  -- r0    : value
   //  -- r2    : name
   //  -- lr    : return address
   //  -- [sp]  : receiver
   // -----------------------------------
-  HandleScope scope;
   Label miss;
 
   __ IncrementCounter(&Counters::keyed_store_field, 1, r1, r3);
 
   // Check that the name has not changed.
   __ cmp(r2, Operand(Handle<String>(name)));
   __ b(ne, &miss);
 
   // Load receiver from the stack.
   __ ldr(r3, MemOperand(sp));
@@ skipping 13 matching lines @@
   __ Jump(ic, RelocInfo::CODE_TARGET);
 
   // Return the generated code.
   return GetCode(transition == NULL ? FIELD : MAP_TRANSITION);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal