Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 27153: Enable the .pak files on mac builds also. (Closed)

Created:
11 years, 10 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
tony, tc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enable the .pak files on mac builds also. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10446

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/grit/grit/tool/build.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
TVL
11 years, 10 months ago (2009-02-25 20:21:06 UTC) #1
tony
http://codereview.chromium.org/27153/diff/1/2 File tools/grit/grit/tool/build.py (right): http://codereview.chromium.org/27153/diff/1/2#newcode164 Line 164: if output.GetType() == 'data_package' and not_windows: I think ...
11 years, 10 months ago (2009-02-25 20:43:23 UTC) #2
TVL
http://codereview.chromium.org/27153/diff/1/2 File tools/grit/grit/tool/build.py (right): http://codereview.chromium.org/27153/diff/1/2#newcode164 Line 164: if output.GetType() == 'data_package' and not_windows: On 2009/02/25 ...
11 years, 10 months ago (2009-02-25 20:50:37 UTC) #3
TVL
On 2009/02/25 20:50:37, TVL wrote: > http://codereview.chromium.org/27153/diff/1/2 > File tools/grit/grit/tool/build.py (right): > > http://codereview.chromium.org/27153/diff/1/2#newcode164 > ...
11 years, 10 months ago (2009-02-25 20:55:38 UTC) #4
TVL
sorry about that, this should have the right logic now.
11 years, 10 months ago (2009-02-25 22:58:50 UTC) #5
tony
11 years, 10 months ago (2009-02-25 23:05:03 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698