Fix import crash in Mac 10.6....

Fix import crash in Mac.

A DictionaryValue we need to keep was being autoreleased in the Mac message loop. The import process uses only C++ code, so we just make a deep copy of the (very small, 5 strings) Dictionary when it's passed into the bridge.

BUG=46003
TEST=import works on Mac OS 10.6 and 10.5

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49284

[jeremy, 2010-06-09 07:47:21]

http://codereview.chromium.org/2715006/diff/4001/5001
File chrome/browser/importer/importer_bridge.cc (right):

http://codereview.chromium.org/2715006/diff/4001/5001#newcode117
chrome/browser/importer/importer_bridge.cc:117: localized_strings_ =
Could you add a comment about why this needs to maintain it's own copy with a
link back to the bug.

http://codereview.chromium.org/2715006/diff/4001/5002
File chrome/browser/importer/importer_bridge.h (right):

http://codereview.chromium.org/2715006/diff/4001/5002#newcode162
chrome/browser/importer/importer_bridge.h:162: DictionaryValue*
localized_strings_;
scoped_ptr<> ? - where is this memory freed?

[Miranda Callahan, 2010-06-09 16:13:06]

Thanks, Jeremy -- fixed.

http://codereview.chromium.org/2715006/diff/4001/5001
File chrome/browser/importer/importer_bridge.cc (right):

http://codereview.chromium.org/2715006/diff/4001/5001#newcode117
chrome/browser/importer/importer_bridge.cc:117: localized_strings_ =
On 2010/06/09 07:47:21, jeremy wrote:
> Could you add a comment about why this needs to maintain it's own copy with a
> link back to the bug.

Done.

http://codereview.chromium.org/2715006/diff/4001/5002
File chrome/browser/importer/importer_bridge.h (right):

http://codereview.chromium.org/2715006/diff/4001/5002#newcode162
chrome/browser/importer/importer_bridge.h:162: DictionaryValue*
localized_strings_;
On 2010/06/09 07:47:21, jeremy wrote:
> scoped_ptr<> ? - where is this memory freed?

D'oh -- made into a scoped_ptr.

[jeremy, 2010-06-09 17:24:17]

LGTM