Issue 27150: Make chrome_plugin_host.cc and chrome_plugin_util.cc compile on Posix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27150: Make chrome_plugin_host.cc and chrome_plugin_util.cc compile on Posix. (Closed)

Created:
11 years, 10 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
jam, Matt Perry

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make chrome_plugin_host.cc and chrome_plugin_util.cc compile on Posix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10436

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -49 lines)			Patch
M	chrome/browser/browser.scons	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_plugin_host.cc	View	1 2 3	10 chunks	+27 lines, -12 lines	0 comments	Download
M	chrome/browser/dom_ui/html_dialog_contents.h	View	2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/modal_html_dialog_delegate.h	View	2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/modal_html_dialog_delegate.cc	View	2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/views/html_dialog_view.h	View	2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/html_dialog_view.cc	View	2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/chrome.xcodeproj/project.pbxproj	View	1 2	4 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_plugin_util.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_plugin_util.cc	View	1 2	3 chunks	+9 lines, -5 lines	1 comment	Download
M	chrome/common/common.scons	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.cc	View	1 2	3 chunks	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

11 years, 10 months ago (2009-02-26 01:30:57 UTC) #2

LGTM

http://codereview.chromium.org/27150/diff/46/52
File chrome/common/chrome_plugin_util.cc (right):

http://codereview.chromium.org/27150/diff/46/52#newcode26
Line 26: url = _strdup(u);
Do we have a cross-platform version of this function (and if not, should we make
one)?  (funny.. I thought strdup was cross platform... thanks microsoft)

Expand Messages | Collapse Messages