Issue 2714016: If CreateDirectory() fails during extension unpacking, log the exact OS call that failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2714016: If CreateDirectory() fails during extension unpacking, log the exact OS call that failed. (Closed)

Created:
10 years, 6 months ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
tkent

CC:
chromium-reviews

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

If CreateDirectory() fails during extension unpacking, log the exact OS call that failed. This change is designed to help understand bug 35198, which we can not reproduce locally. BUG=35198 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49703

Patch Set 1 #

Patch Set 2 : Add a bit more logging. #

Patch Set 3 : Rebase for commit. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -23 lines)			Patch
M	base/file_util.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	base/file_util_win.cc	View	1	2 chunks	+44 lines, -20 lines	0 comments	Download
M	chrome/common/extensions/extension_unpacker.cc	View		1 chunk	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages