Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2030)

Issue 2714007: Initial code for screen differ that divides screen into blocks and calculate... (Closed)

Created:
10 years, 6 months ago by garykac
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Initial code for screen differ that divides screen into blocks and calculate a 'minimal' set of rectangles that covers the changed region. BUG=none TEST=new unittests added Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49325

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+842 lines, -0 lines) Patch
A remoting/host/differ.h View 1 2 3 4 1 chunk +86 lines, -0 lines 0 comments Download
A remoting/host/differ.cc View 1 2 3 4 1 chunk +226 lines, -0 lines 0 comments Download
A remoting/host/differ_unittest.cc View 1 2 3 4 1 chunk +530 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
garykac
10 years, 6 months ago (2010-06-09 17:50:47 UTC) #1
Paweł Hajdan Jr.
Drive-by with a minor test comment. http://codereview.chromium.org/2714007/diff/5001/6003 File remoting/host/differ_unittest.cc (right): http://codereview.chromium.org/2714007/diff/5001/6003#newcode219 remoting/host/differ_unittest.cc:219: EXPECT_EQ(1, GetDiffInfo(x, y)); ...
10 years, 6 months ago (2010-06-09 17:57:10 UTC) #2
garykac
http://codereview.chromium.org/2714007/diff/5001/6003 File remoting/host/differ_unittest.cc (right): http://codereview.chromium.org/2714007/diff/5001/6003#newcode219 remoting/host/differ_unittest.cc:219: EXPECT_EQ(1, GetDiffInfo(x, y)); On 2010/06/09 17:57:10, Paweł Hajdan Jr. ...
10 years, 6 months ago (2010-06-09 18:23:13 UTC) #3
Paweł Hajdan Jr.
Code I commented in the drive-by LGTM.
10 years, 6 months ago (2010-06-09 18:36:05 UTC) #4
Alpha Left Google
10 years, 6 months ago (2010-06-09 18:51:17 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld 408576698