Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 27134: Remove PCRE files from Xcode project. (Closed)

Created:
11 years, 10 months ago by iposva
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove PCRE files from Xcode project. Committed: http://code.google.com/p/v8/source/detail?r=1367

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M tools/v8.xcodeproj/project.pbxproj View 8 chunks +0 lines, -43 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
iposva
11 years, 10 months ago (2009-02-25 14:51:01 UTC) #1
Mads Ager (chromium)
LGTM, thanks!
11 years, 10 months ago (2009-02-25 14:52:39 UTC) #2
Mark Mentovai
LGTM http://codereview.chromium.org/27134/diff/1/2 File tools/v8.xcodeproj/project.pbxproj (left): http://codereview.chromium.org/27134/diff/1/2#oldcode1139 Line 1139: 897FF1BC0E719CB600D62E90 /* Sources */ = { Is ...
11 years, 10 months ago (2009-02-25 14:53:29 UTC) #3
iposva
11 years, 10 months ago (2009-02-25 16:23:05 UTC) #4
http://codereview.chromium.org/27134/diff/1/2
File tools/v8.xcodeproj/project.pbxproj (left):

http://codereview.chromium.org/27134/diff/1/2#oldcode1139
Line 1139: 897FF1BC0E719CB600D62E90 /* Sources */ = {
On 2009/02/25 14:53:29, Mark Mentovai wrote:
> Is there a target that needs to be removed too?

Targets were removed in an earlier change...

Powered by Google App Engine
This is Rietveld 408576698