- Pass the knowledge whether the old GC is compacting to the GC prologue and ...

- Pass the knowledge whether the old GC is compacting to the GC prologue and epilogue. This allows us to skip frame cooking and uncooking when doing a mark-sweep GC.
- Add the ability for the code to refer to its code object by adding a handle to the code object in the MacroAssembler.


Committed: http://code.google.com/p/v8/source/detail?r=1368

[Kevin Millikin (Chromium), 2009-02-25 14:54:33]

The GC and allocation stuff looks good.

http://codereview.chromium.org/27133/diff/1/22
File src/accessors.cc (right):

http://codereview.chromium.org/27133/diff/1/22#newcode391
Line 391: Heap::arguments_symbol());
Screwy indentation here.

[Kasper Lund, 2009-02-25 15:00:19]

LGTM.

http://codereview.chromium.org/27133/diff/1/22
File src/accessors.cc (right):

http://codereview.chromium.org/27133/diff/1/22#newcode391
Line 391: Heap::arguments_symbol());
Indentation is slightly off here.

http://codereview.chromium.org/27133/diff/1/6
File src/macro-assembler-arm.h (right):

http://codereview.chromium.org/27133/diff/1/6#newcode233
Line 233: Handle<Object> CodeObject() {
Fits on one line?

http://codereview.chromium.org/27133/diff/1/21
File src/macro-assembler-ia32.h (right):

http://codereview.chromium.org/27133/diff/1/21#newcode238
Line 238: Handle<Object> CodeObject() {
Fits on one line?

http://codereview.chromium.org/27133/diff/1/34
File src/stub-cache.h (right):

http://codereview.chromium.org/27133/diff/1/34#newcode370
Line 370: HandleScope scope_;
This should allow you to get rid of a lot of HandleScopes inside the GenerateXXX
functions.

[iposva, 2009-02-25 16:42:53]

http://codereview.chromium.org/27133/diff/1/22
File src/accessors.cc (right):

http://codereview.chromium.org/27133/diff/1/22#newcode391
Line 391: Heap::arguments_symbol());
On 2009/02/25 15:00:19, Kasper Lund wrote:
> Indentation is slightly off here.

Done.

http://codereview.chromium.org/27133/diff/1/22#newcode391
Line 391: Heap::arguments_symbol());
On 2009/02/25 14:54:33, Kevin Millikin wrote:
> Screwy indentation here.

Done.

http://codereview.chromium.org/27133/diff/1/6
File src/macro-assembler-arm.h (right):

http://codereview.chromium.org/27133/diff/1/6#newcode233
Line 233: Handle<Object> CodeObject() {
On 2009/02/25 15:00:19, Kasper Lund wrote:
> Fits on one line?

Done.

http://codereview.chromium.org/27133/diff/1/21
File src/macro-assembler-ia32.h (right):

http://codereview.chromium.org/27133/diff/1/21#newcode238
Line 238: Handle<Object> CodeObject() {
On 2009/02/25 15:00:19, Kasper Lund wrote:
> Fits on one line?

Done.

http://codereview.chromium.org/27133/diff/1/34
File src/stub-cache.h (right):

http://codereview.chromium.org/27133/diff/1/34#newcode370
Line 370: HandleScope scope_;
On 2009/02/25 15:00:19, Kasper Lund wrote:
> This should allow you to get rid of a lot of HandleScopes inside the
GenerateXXX
> functions.

Done.