Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 27117: Add a new message id IDS_LOGIN_DIALOG_DESCRIPTION_NO_REALM, which... (Closed)

Created:
11 years, 10 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
tony, eroman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a new message id IDS_LOGIN_DIALOG_DESCRIPTION_NO_REALM, which is a variant of IDS_LOGIN_DIALOG_DESCRIPTION that doesn't have a realm. Some HTTP authentication schemes such as NTLM don't have a realm. In IDS_LOGIN_DIALOG_DESCRIPTION, changed the placeholder's name from "TITLE" to "REALM". R=eroman,tony BUG=6567, 6824 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/login_prompt.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
11 years, 10 months ago (2009-02-25 01:34:04 UTC) #1
eroman
lgtm
11 years, 10 months ago (2009-02-25 01:52:57 UTC) #2
tony
11 years, 10 months ago (2009-02-25 02:18:58 UTC) #3
LGTM2

Powered by Google App Engine
This is Rietveld 408576698