Issue 271094: Don't use NSBundle when unsure of thread safety

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271094: Don't use NSBundle when unsure of thread safety (Closed)

Created:
11 years, 2 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, brettw+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't use NSBundle when unsure of thread safety. BUG=24842 TEST=unit tests pass, app still works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29077

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -31 lines)			Patch
M	base/base_paths_mac.mm	View	1 2 3 4 5 6 7 8	3 chunks	+11 lines, -12 lines	0 comments	Download
M	chrome/common/chrome_paths_internal.h	View	4 5	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/common/chrome_paths_mac.mm	View	2 3 4 5 6 7	2 chunks	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

11 years, 2 months ago (2009-10-15 00:30:55 UTC) #2

LG

should we think about DCHECKs in base/mac_util for some of the bundle uses
there?  I can't find any docs on CFBundle and thread safety, maybe using that
there is safe?

Expand Messages | Collapse Messages