Issue 271086: Remove file_util::TrimTrailingSeparators(), which is deprecated and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271086: Remove file_util::TrimTrailingSeparators(), which is deprecated and... (Closed)

Created:
11 years, 2 months ago by tkent

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, tim (not reviewing), brettw+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Remove file_util::TrimTrailingSeparators(), which is deprecated and doesn't work well for Windows root drives. BUG=24722 TEST=existing tests are enough. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29093

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -24 lines)			Patch
M	base/file_util.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/file_util.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/file_util_posix.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	base/file_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_util_win.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/test/mini_installer_test/chrome_mini_installer.cc	View	1 chunk	+5 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM