Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 271085: - Add String::Concat(Handle<String> left, Handle<String> right) to the V8 API... (Closed)

Created:
11 years, 2 months ago by iposva
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

- Add String::Concat(Handle<String> left, Handle<String> right) to the V8 API. This is the first step to address http://crbug.com/23131 by creating a series of V8 ConsStrings as more data arrives from the server. Committed: http://code.google.com/p/v8/source/detail?r=3066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M include/v8.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
iposva
11 years, 2 months ago (2009-10-14 05:21:13 UTC) #1
Christian Plesner Hansen
As I understand the issue there are two problems we're trying to solve: 1, concatenation ...
11 years, 2 months ago (2009-10-14 08:35:57 UTC) #2
Christian Plesner Hansen
11 years, 2 months ago (2009-10-14 14:39:50 UTC) #3
After discussing this with Ivan: Lgtm!  It seems that people usually don't use
intermediate results so this should work fine.

Powered by Google App Engine
This is Rietveld 408576698