Skip access checks for hidden properties.

Skip access checks for hidden properties.

Hidden properties are used like internal fields which do not have
access checks. The checks can cause problems because there may be no
current context. See http://crbug.com/24200.

Committed: http://code.google.com/p/v8/source/detail?r=3062

[Christian Plesner Hansen, 2009-10-14 08:20:37]

Lgtm.

I'm not 100% comfortable with the approach of always allowing access through the
hidden symbol though.  I would have preferred a model where the access model
stayed as it was but could be disabled altogether when called from the GetHidden
methods.  However, I can't think of a nice way of doing that so I'm okay with
doing it this way.

[Vitaly Repeshko, 2009-10-14 10:27:41]

On 2009/10/14 08:20:37, Christian Plesner Hansen wrote:
> Lgtm.
> 
> I'm not 100% comfortable with the approach of always allowing access through
the
> hidden symbol though.  I would have preferred a model where the access model
> stayed as it was but could be disabled altogether when called from the
GetHidden
> methods.  However, I can't think of a nice way of doing that so I'm okay with
> doing it this way.

Yes, I would also prefer to have the checks disabled only when called from
GetHidden functions. To avoid code duplication and map manipulation we could add
a parameter to Object::GetProperty* functions, but still it doesn't sound really
nice.

[Christian Plesner Hansen, 2009-10-14 11:16:23]

> Yes, I would also prefer to have the checks disabled only when called from
> GetHidden functions. To avoid code duplication and map manipulation we could
add
> a parameter to Object::GetProperty* functions, but still it doesn't sound
really
> nice.

I agree -- and we would have to add it to HasLocalProperty too.