Issue 271053: Check that constructor is a FunctionMirror before calling .name()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271053: Check that constructor is a FunctionMirror before calling .name() (Closed)

Created:
11 years, 2 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, mnaganov (inactive)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Check that constructor is a FunctionMirror before calling .name(), otherwise we may end up calling name method on a mirror object that doesn't have it. Committed: http://code.google.com/p/v8/source/detail?r=3057

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -1 line)			Patch
	M	src/mirror-delay.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/debug-evaluate-bool-constructor.js	View	1	1 chunk	+80 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

11 years, 2 months ago (2009-10-13 14:24:29 UTC) #3

LGTM

http://codereview.chromium.org/271053/diff/3001/4001
File test/mjsunit/debug-evaluate-bool-constructor.js (right):

http://codereview.chromium.org/271053/diff/3001/4001#newcode62
Line 62: exception = e
nit: bad indentation here.

Expand Messages | Collapse Messages