Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 271046: Revert 28558 because this is clearly responsible for... (Closed)

Created:
11 years, 2 months ago by Nicolas Sylvain
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Revert 28558 because this is clearly responsible for breaking the interactive ui tests. It just needs a clobber. It looks like 2 parts of the code don't agree on the number of buttons on the bookmark bar. Maybe because part of the code is compiled with CHROME_PERSONALIZATION = 1 while the test is compiled with CHROME_PERSONALIZATION = 0. Maybe this new gyp change broke the define propagation. This is really easy to replicate, and should also be easy to debug. Original Log: Relanding the interactive UI tests GYP factor out, as it turns out it is not responsible for breaking the interactive ui tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -3 lines) Patch
M build/all.gyp View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome.gyp View 3 chunks +267 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nicolas Sylvain
11 years, 2 months ago (2009-10-10 18:47:29 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698