Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 27085: Add socket support to platform code.... (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add socket support to platform code. The new Socket class is an encapsulation of the standard BSD socket API. As it depends on platform specific include files and have some slight platform variations it is part of the platform code. On Mac OS only the option SO_REUSEADDR is set to true for server sockets. Running the test required it as the bound listener socket would sometimes end up in TIME_WAIT. On Windows and Linux this has never been observed (given the client end of the socket is closed before the server end). The code has been tested on Windows, Linux and Mac OS. The FreeBSD version is a copy of the Linux version but has not been compiled nor tested. Missing Xcode project updates. Committed: http://code.google.com/p/v8/source/detail?r=1349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+894 lines, -19 lines) Patch
M SConstruct View 6 chunks +8 lines, -8 lines 0 comments Download
M src/platform.h View 3 chunks +39 lines, -0 lines 0 comments Download
M src/platform-freebsd.cc View 3 chunks +171 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 3 chunks +172 lines, -0 lines 0 comments Download
M src/platform-macos.cc View 2 chunks +179 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +175 lines, -0 lines 0 comments Download
M test/cctest/SConscript View 1 chunk +2 lines, -1 line 0 comments Download
A test/cctest/test-sockets.cc View 1 chunk +134 lines, -0 lines 0 comments Download
M tools/visual_studio/d8.vcproj View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/visual_studio/v8_cctest.vcproj View 3 chunks +6 lines, -2 lines 0 comments Download
M tools/visual_studio/v8_mksnapshot.vcproj View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/visual_studio/v8_process_sample.vcproj View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/visual_studio/v8_shell_sample.vcproj View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
The code for each of the four platforms is almost identical. The differences are: initialization ...
11 years, 10 months ago (2009-02-24 10:25:11 UTC) #1
Mads Ager (chromium)
11 years, 10 months ago (2009-02-24 13:21:04 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698