Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2436)

Unified Diff: tools/purify/common.py

Issue 27079: Support for running unit-tests under valgrind on Mac (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/chrome_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/purify/common.py
===================================================================
--- tools/purify/common.py (revision 10216)
+++ tools/purify/common.py (working copy)
@@ -128,8 +128,9 @@
elif not detach:
for line in p.stdout.readlines():
_print_line(line, False)
- logging.info("flushing stdout")
- p.stdout.flush()
+ if sys.platform != 'darwin': # stdout flush fails on Mac
+ logging.info("flushing stdout")
+ p.stdout.flush()
logging.info("collecting result code")
result = p.poll()
@@ -331,6 +332,3 @@
except:
logging.warning("unable to delete file %s: %s" % (file,
sys.exc_info()[0]))
-
-
-
« no previous file with comments | « no previous file | tools/valgrind/chrome_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698