Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 27054: Multiple fixes for broken Linux SHARED=1 build. (Closed)

Created:
11 years, 10 months ago by Michael Moss
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, Evan Martin, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Multiple fixes for broken Linux SHARED=1 build. This gets things building, but the resulting 'chrome' binary crashes on start-up (test_shell seems to work better).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -9 lines) Patch
M build/SConscript.main View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser.scons View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/debugger/debugger.scons View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/renderer.scons View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/unit/unit_tests.scons View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/third_party/hunspell/SConscript View 1 chunk +14 lines, -2 lines 0 comments Download
M chrome/tools/convert_dict/convert_dict.scons View 2 chunks +3 lines, -2 lines 0 comments Download
M net/net_lib.scons View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/build/WebCore/SConscript View 1 chunk +5 lines, -1 line 0 comments Download
M webkit/glue/SConscript View 1 chunk +8 lines, -1 line 0 comments Download
M webkit/tools/test_shell/SConscript View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Moss
Should we have a "SHARED=1" builder to make sure this doesn't get so badly out ...
11 years, 10 months ago (2009-02-23 18:59:19 UTC) #1
Evan Martin
The crash is likely in spell checker code, which I fixed here: http://codereview.chromium.org/27036/show That also ...
11 years, 10 months ago (2009-02-23 19:41:46 UTC) #2
Michael Moss
> That also builds shared for me. Maybe I'm pulling in some old .as though. ...
11 years, 10 months ago (2009-02-23 19:50:28 UTC) #3
Lei Zhang
The changes to build/SConscript.main, chrome/test/unit/unit_tests.scons, chrome/third_party/hunspell/SConscript, and chrome/tools/convert_dict/convert_dict.scons is all I needed to fix the ...
11 years, 10 months ago (2009-02-23 22:13:18 UTC) #4
Michael Moss
This works for you with a clean build and checkout? I still get errors if ...
11 years, 10 months ago (2009-02-23 22:49:34 UTC) #5
Lei Zhang
11 years, 10 months ago (2009-02-23 23:55:16 UTC) #6
LGTM

The changes make sense. It seems we had some build differences between dbg and
opt?

Powered by Google App Engine
This is Rietveld 408576698