Issue 27046: Patch (SSE3) for faster To(U)Int32 conversion in bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27046: Patch (SSE3) for faster To(U)Int32 conversion in bit (Closed)

Created:
11 years, 10 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
olehougaard, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Use SSE3 instructions - if available - for faster To(U)Int32 conversion in bit operation stubs. Disable serialization support by default to allow us to use SSE3 instructions and faster write barrier code when running without snapshot. Committed: http://code.google.com/p/v8/source/detail?r=1364

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -61 lines)			Patch
M	src/api.cc	View	3	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/assembler-ia32.h	View	1 2 3	4 chunks	+10 lines, -7 lines	0 comments	Download
M	src/assembler-ia32.cc	View	1 2 3	4 chunks	+46 lines, -15 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1 2 3	2 chunks	+46 lines, -21 lines	0 comments	Download
M	src/cpu-ia32.cc	View	3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/mksnapshot.cc	View	3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/serialize.h	View	3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/serialize.cc	View	3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/v8.cc	View	3	2 chunks	+5 lines, -3 lines	1 comment	Download
M	test/cctest/test-assembler-ia32.cc	View	3	4 chunks	+0 lines, -8 lines	0 comments	Download
M	test/cctest/test-disasm-ia32.cc	View	3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	3	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

New SSE3 code for you Mads. We now check for SSE3 support and fall back ...

11 years, 10 months ago (2009-02-25 14:05:35 UTC) #1

Mads Ager (chromium)

Looks great! http://codereview.chromium.org/27046/diff/20/1044 File src/v8.cc (right): http://codereview.chromium.org/27046/diff/20/1044#newcode85 Line 85: // objects in place for creating ...

11 years, 10 months ago (2009-02-25 14:34:05 UTC) #2

LGTM

Expand Messages | Collapse Messages