Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 27037: Implement GM_xmlhttpRequest (Closed)

Created:
11 years, 10 months ago by skrulx
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Committed in r10886.

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -256 lines) Patch
M chrome/renderer/extensions/greasemonkey_api_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/resources/greasemonkey_api.js View 1 1 chunk +41 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/greasemonkey_api_test.js View 1 5 chunks +128 lines, -198 lines 0 comments Download
M chrome/test/v8_unit_test.h View 1 2 chunks +1 line, -50 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
skrulx
The implementation of GM_xmlHttpRequest :) This patch also includes a fix to GM_addStyle so it ...
11 years, 10 months ago (2009-02-21 23:22:07 UTC) #1
Aaron Boodman
http://codereview.chromium.org/27037/diff/1/5 File chrome/renderer/resources/greasemonkey_api.js (right): http://codereview.chromium.org/27037/diff/1/5#newcode70 Line 70: if (!head) { You can add the style ...
11 years, 10 months ago (2009-02-21 23:32:57 UTC) #2
skrulx
http://codereview.chromium.org/27037/diff/1/5 File chrome/renderer/resources/greasemonkey_api.js (right): http://codereview.chromium.org/27037/diff/1/5#newcode70 Line 70: if (!head) { On 2009/02/21 23:32:57, Aaron Boodman ...
11 years, 10 months ago (2009-02-25 23:32:12 UTC) #3
skrulx
OK, updated version up.
11 years, 10 months ago (2009-02-26 01:46:03 UTC) #4
Aaron Boodman
LGTM!
11 years, 10 months ago (2009-02-26 01:55:00 UTC) #5
Aaron Boodman
11 years, 10 months ago (2009-02-26 01:55:18 UTC) #6
On 2009/02/26 01:55:00, Aaron Boodman wrote:
> LGTM!

(I will check this in soon)

Powered by Google App Engine
This is Rietveld 408576698