Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2702001: Add platform_locale_settings file for CrOS. This is necessary because... (Closed)

Created:
10 years, 6 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, kanliu, finnur+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Add platform_locale_settings file for CrOS. This is necessary because fonts available on CrOS are different from fonts on typical Linux disributions. BUG=cros:3815 (http://crosbug.com/3815) TEST=Go to a web page that only specifies CSS generic families (e.g. sans-serif,serif, monospace) and make sure that Ascender Sans, Ascender Serif are used. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49236

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : identical to the prev. patch, but used svn cp #

Patch Set 5 : fix cros unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -39 lines) Patch
A + chrome/app/resources/locale_settings_cros.grd View 1 2 3 4 2 chunks +54 lines, -54 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_am.xtb View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_ar.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_bg.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_bn.xtb View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_ca.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_cs.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_da.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_de.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_el.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_en-GB.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_es.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_es-419.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_et.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_fi.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_fil.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_fr.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_gu.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_he.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_hi.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_hr.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_hu.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_id.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_it.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_ja.xtb View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_kn.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_ko.xtb View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_lt.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_lv.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_ml.xtb View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_mr.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_nb.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_nl.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_pl.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_pt-BR.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_pt-PT.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_ro.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_ru.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_sk.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_sl.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_sr.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_sv.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_sw.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_ta.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_te.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_th.xtb View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_tr.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_uk.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_vi.xtb View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-CN.xtb View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
A + chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-TW.xtb View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jungshik at Google
To: Kan This is not essential for R7 (CrOS), but is a prep for further ...
10 years, 6 months ago (2010-06-05 17:15:28 UTC) #1
tony
Does Ascender have the same font metrics as Times New Roman and Arial? Otherwise, I ...
10 years, 6 months ago (2010-06-07 00:56:09 UTC) #2
jungshik at Google
On 2010/06/07 00:56:09, tony wrote: > Does Ascender have the same font metrics as Times ...
10 years, 6 months ago (2010-06-07 19:20:11 UTC) #3
jungshik at Google
Tony, if you don't feel strongly about the other way you suggested, could you review ...
10 years, 6 months ago (2010-06-09 00:37:06 UTC) #4
tony
10 years, 6 months ago (2010-06-09 00:46:33 UTC) #5
On 2010/06/09 00:37:06, Jungshik Shin wrote:
> Tony, if you don't feel strongly about the other way you suggested, could you
> review this (as it is)?

Sorry! I didn't see your previous comment.  Yes, LGTM!

Powered by Google App Engine
This is Rietveld 408576698