Issue 270101: Move the sqlite error handler to a single location...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270101: Move the sqlite error handler to a single location... (Closed)

Created:
11 years, 2 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
huanr, jar (doing other things)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move the sqlite error handler to a single location - Eliminate code duplication - Cover other 3 databases - Still doing the same as before, sending UMA histograms BUG=11908 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29073

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -44 lines)			Patch
M	chrome/browser/diagnostics/sqlite_diagnostics.h	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/diagnostics/sqlite_diagnostics.cc	View	1	1 chunk	+66 lines, -0 lines	1 comment	Download
M	chrome/browser/history/history_database.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/history/text_database.cc	View	1	3 chunks	+2 lines, -22 lines	0 comments	Download
M	chrome/browser/history/thumbnail_database.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/net/sqlite_persistent_cookie_store.cc	View		3 chunks	+2 lines, -22 lines	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

11 years, 2 months ago (2009-10-15 06:44:28 UTC) #3

The suggestion below may be more applicable to the newer names, given that you
already had some of these histogram names in use.

http://codereview.chromium.org/270101/diff/4001/5001
File chrome/browser/diagnostics/sqlite_diagnostics.cc (right):

http://codereview.chromium.org/270101/diff/4001/5001#newcode19
Line 19: "Sqlite.Web.Error"
Not a big deal... but... Given these will be sorted with other Sqlite.*
histograms, you might prefer to get them bunched together by naming them:
Sqlite.Error.Cookie
Sqlite.Error.History
etc.

Expand Messages | Collapse Messages