Issue 2701003: Revert r4782. Fix issues 728, 732.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2701003: Revert r4782. Fix issues 728, 732. (Closed)

Created:
10 years, 6 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

Revert r4782. Fix issues 728, 732. Committed: http://code.google.com/p/v8/source/detail?r=4806

Patch Set 2 : fix arm compilation issue #

Total comments: 2

Patch Set 3 : fix review remarks, add static checks #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -20 lines)			Patch
M	src/arm/ic-arm.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects.h	View	1 2	2 chunks	+25 lines, -8 lines	1 comment	Download
M	src/objects.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/utils.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x64/ic-x64.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/2701003/diff/3001/4001 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/2701003/diff/3001/4001#newcode838 src/arm/ic-arm.cc:838: __ b(eq, &index_string); Why change the value of ...

10 years, 6 months ago (2010-06-07 09:06:15 UTC) #2