Issue 270092: Fixes bug in toolkit_views. We shouldn't set the theme provider for...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270092: Fixes bug in toolkit_views. We shouldn't set the theme provider for... (Closed)

Created:
11 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes bug in toolkit_views. We shouldn't set the theme provider for widget_gtk when building chromeos build. We need a #ifdef for CHROMEOS but not using TOOLKIT_VIEWs for the browser window. I'm temporarily adding this one. This bug is the result of Oshima making TOOLKIT_VIEWS set OS_CHROMEOS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28916

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	views/widget/widget_gtk.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages