Issue 270086: Match Window's behavior when recursively copying directories that exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270086: Match Window's behavior when recursively copying directories that exist. (Closed)

Created:
11 years, 2 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
sgk

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, tim (not reviewing), brettw+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Match window's behavior when recursively copying directories that exist. Unit test improvement from here (sgk): http://codereview.chromium.org/271060 BUG=none TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28838

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -5 lines)			Patch
	M	base/file_util_posix.cc	View		2 chunks	+11 lines, -2 lines	2 comments	Download
	M	base/file_util_unittest.cc	View		5 chunks	+142 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

vandebo (ex-Chrome)

Fixed the issue and added another unit test for MoveDir, which uses CopyDir in the ...

11 years, 2 months ago (2009-10-13 17:31:19 UTC) #1

sgk

code two lgtm, two spelling nits in the comments (thanks for fixing this!) http://codereview.chromium.org/270086/diff/1/2 File ...

11 years, 2 months ago (2009-10-13 17:49:13 UTC) #2

Oops, fixed.