Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 270067: Converts some uses of native_view to native_window. This is necessitated... (Closed)

Created:
11 years, 2 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Converts some uses of native_view to native_window. This is necessitated by wanting to parent bookmarkeditor to browserwindow, which returns a native_window. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28728

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -149 lines) Patch
M chrome/browser/bookmarks/bookmark_context_menu_controller.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_editor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/clock_menu_button.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/clock_menu_button.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/network_menu_button.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/network_menu_button.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/power_menu_button.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/power_menu_button.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/status_area_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/status_area_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmark_editor_controller.mm View 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/gtk/bookmark_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_context_menu_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/bookmark_context_menu_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/bookmark_editor_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/bookmark_manager_gtk.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/gtk/bookmark_menu_controller_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/input_window_dialog.h View 3 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/input_window_dialog_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/views/bookmark_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_context_menu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/bookmark_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_manager_view.h View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/views/bookmark_manager_view.cc View 5 chunks +8 lines, -12 lines 1 comment Download
M chrome/browser/views/bookmark_menu_button.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/views/bookmark_menu_button.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/views/bookmark_menu_controller_views.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/bookmark_menu_controller_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/toolbar_view.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M views/controls/button/menu_button.cc View 3 chunks +7 lines, -20 lines 0 comments Download
M views/controls/menu/menu_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/menu/menu_host_gtk.h View 1 chunk +3 lines, -1 line 0 comments Download
M views/controls/menu/menu_host_gtk.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M views/controls/menu/menu_host_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M views/controls/menu/menu_item_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_item_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/submenu_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/menu/submenu_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/menu/view_menu_delegate.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
This looks bigger than it is. I'm just converting a bunch of NativeView uses to ...
11 years, 2 months ago (2009-10-12 18:27:04 UTC) #1
jcampan
11 years, 2 months ago (2009-10-12 18:44:06 UTC) #2 
LGTM

http://codereview.chromium.org/270067/diff/1065/96
File chrome/browser/views/bookmark_manager_view.cc (right):

http://codereview.chromium.org/270067/diff/1065/96#newcode751
Line 751: BookmarkContextMenu menu(GetWindow()->GetNativeWindow(), profile_,
NULL, parent,
More than 80 chars

Powered by Google App Engine
This is Rietveld 408576698