chrome/installer/util/google_chrome_distribution.cc - Issue 270062: Use ASCII strings for switch names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 270062: Use ASCII strings for switch names. (Closed)

Patch Set: victory Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/google_chrome_distribution.cc

diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc

index bed5b83631550dde01879a9ee924756ffa4055b3..3dd86995152e4223efae9872e71ec539f85f8b22 100644

--- a/chrome/installer/util/google_chrome_distribution.cc

+++ b/chrome/installer/util/google_chrome_distribution.cc

@@ -106,7 +106,8 @@ int GetDirectoryWriteAgeInHours(const wchar_t* path) {

// Does not wait for the process to terminate.

bool RelaunchSetup(const std::wstring& flag, int value) {

CommandLine cmd_line(CommandLine::ForCurrentProcess()->program());

- cmd_line.AppendSwitchWithValue(flag, IntToWString(value));

+ // TODO: make switches into ASCII.

+ cmd_line.AppendSwitchWithValue(WideToASCII(flag), IntToWString(value));

return base::LaunchApp(cmd_line, false, false, NULL);

}

« no previous file with comments | « chrome/common/sandbox_init_wrapper.cc ('k') | chrome/installer/util/logging_installer.cc » ('j') | no next file with comments »