Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 270047: Fix gcl opened, gcl nothave, and gcl status to:... (Closed)

Created:
11 years, 2 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com, M-A Ruel
Visibility:
Public.

Description

Fix gcl opened, gcl nothave, and gcl status to: * Actually print unknown files * Put things in the proper order (i.e. files with no changelist under the "no changelist" header) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28719

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M gcl.py View 1 2 3 2 chunks +23 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Kasting
11 years, 2 months ago (2009-10-09 19:19:46 UTC) #1
M-A Ruel
http://codereview.chromium.org/270047/diff/1/2 File gcl.py (right): http://codereview.chromium.org/270047/diff/1/2#newcode623 Line 623: if ((len(files) and len(files[""])) maybe that instead? if ...
11 years, 2 months ago (2009-10-09 19:34:34 UTC) #2
Peter Kasting
Thanks for the comments, fixed all. Have another look.
11 years, 2 months ago (2009-10-09 20:01:00 UTC) #3
M-A Ruel
http://codereview.chromium.org/270047/diff/2002/1005 File gcl.py (right): http://codereview.chromium.org/270047/diff/2002/1005#newcode625 Line 625: if files.get(''): for file in files.get('', []):
11 years, 2 months ago (2009-10-09 21:14:52 UTC) #4
Peter Kasting
http://codereview.chromium.org/270047/diff/2002/1005 File gcl.py (right): http://codereview.chromium.org/270047/diff/2002/1005#newcode625 Line 625: if files.get(''): On 2009/10/09 21:14:52, Marc-Antoine Ruel wrote: ...
11 years, 2 months ago (2009-10-09 21:20:51 UTC) #5
M-A Ruel
11 years, 2 months ago (2009-10-12 17:56:50 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698