Password style support for gtk's textfield impl....

* Password style support for gtk's textfield impl.
* Added x11 dependency to view_examples. Looks like dependency has changed a bit.

BUG=none
TEST=build & run view_examples target.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28501

[brettw, 2009-10-08 22:37:00]

http://codereview.chromium.org/270032/diff/6006/6008
File views/controls/textfield/native_textfield_gtk.cc (right):

http://codereview.chromium.org/270032/diff/6006/6008#newcode16
Line 16: const gunichar kPasswordChar = g_utf8_get_char("*");
We don't want to have a function call since this is a static. This function will
get called before main, may bring in libraries earlier than we were before, etc.
Since this is just ASCII, I would use a char and cast when you use it.

http://codereview.chromium.org/270032/diff/6006/6010
File views/examples/textfield_example.h (right):

http://codereview.chromium.org/270032/diff/6006/6010#newcode51
Line 51: // Textfield::Controller implementations:
Style guide says no blank line after "private"

http://codereview.chromium.org/270032/diff/6006/6010#newcode65
Line 65: return FALSE;
s/FALSE/false/

[oshima, 2009-10-08 23:18:32]

http://codereview.chromium.org/270032/diff/6006/6008
File views/controls/textfield/native_textfield_gtk.cc (right):

http://codereview.chromium.org/270032/diff/6006/6008#newcode16
Line 16: const gunichar kPasswordChar = g_utf8_get_char("*");
On 2009/10/08 22:37:01, brettw wrote:
> We don't want to have a function call since this is a static. This function
will
> get called before main, may bring in libraries earlier than we were before,
etc.
You're right. done.
> Since this is just ASCII, I would use a char and cast when you use it.

Did't know UTF32 also shares the code with iso8859. Thanks.

http://codereview.chromium.org/270032/diff/6006/6010
File views/examples/textfield_example.h (right):

http://codereview.chromium.org/270032/diff/6006/6010#newcode51
Line 51: // Textfield::Controller implementations:
On 2009/10/08 22:37:01, brettw wrote:
> Style guide says no blank line after "private"

Done.

http://codereview.chromium.org/270032/diff/6006/6010#newcode65
Line 65: return FALSE;
On 2009/10/08 22:37:01, brettw wrote:
> s/FALSE/false/

Done.

[brettw, 2009-10-08 23:49:00]

LGTM