Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2700002: Linux: add gnome-keyring packages to build dependencies. (Closed)

Created:
10 years, 6 months ago by Mike Mammarella
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, M-A Ruel
CC:
Evan Stade, chromium-reviews
Visibility:
Public.

Description

Linux: add gnome-keyring packages to build dependencies. It will not be a runtime dependency: it will be dlopen()ed to avoid that. BUG=25404 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49110

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M build/install-build-deps.sh View 1 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike Mammarella
See password_store_gnome.cc for the dlopen() code. This package will also need to be added to ...
10 years, 6 months ago (2010-06-05 21:40:20 UTC) #1
Lei Zhang
LGTM Please let chromium-dev know and wait for maruel to install this on all the ...
10 years, 6 months ago (2010-06-07 18:44:05 UTC) #2
M-A Ruel
10 years, 6 months ago (2010-06-07 18:46:52 UTC) #3
I was already mass updating for libpulse-dev. Restarting over now...

lgtm

Powered by Google App Engine
This is Rietveld 408576698