Issue 2698002: Update metrics daemon to use new power manager signals for locking (4 of 7).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2698002: Update metrics daemon to use new power manager signals for locking (4 of 7). (Closed)

Created:
10 years, 6 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
petkov, Sameer Nanda

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/metrics.git

Visibility:
Public.

Description

Update metrics daemon to use new power manager signals for locking (4 of 7). Co-dependent with the following change: - Issue 2685003: Update XScreenSaver to use new power manager signals for locking (3 of 7). TEST=Ran test suite. BUG=chromium-os:3694

Patch Set 1 : Update to master #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -130 lines)			Patch
M	metrics_daemon.h	View	5 chunks	+0 lines, -21 lines	0 comments	Download
M	metrics_daemon.cc	View	5 chunks	+12 lines, -45 lines	0 comments	Download
M	metrics_daemon_test.cc	View	4 chunks	+6 lines, -47 lines	0 comments	Download
D	screensaver_states.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sameer Nanda

10 years, 6 months ago (2010-06-07 01:41:14 UTC) #3

LGTM

On Fri, Jun 4, 2010 at 5:50 PM, <petkov@chromium.org> wrote:

> LGTM
>
>
>
> http://codereview.chromium.org/2698002/show
>



-- 
Sameer

Expand Messages | Collapse Messages