Issue 2696002: Linux: make GNOME keyring password store able to use libgnome-keyring via dlopen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2696002: Linux: make GNOME keyring password store able to use libgnome-keyring via dlopen. (Closed)

Created:
10 years, 6 months ago by Mike Mammarella

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Linux: make GNOME keyring password store able to use libgnome-keyring via dlopen. The GNOME keyring password store is still disabled. BUG=25404 TEST=gnome keyring password store can be loaded with dlopen Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48996

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -2 lines)			Patch
	M	chrome/browser/password_manager/password_store_gnome.cc	View	1	4 chunks	+120 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm http://codereview.chromium.org/2696002/diff/1/2 File chrome/browser/password_manager/password_store_gnome.cc (right): http://codereview.chromium.org/2696002/diff/1/2#newcode55 chrome/browser/password_manager/password_store_gnome.cc:55: typeof(&gnome_keyring_##name) name = wrap_gnome_keyring_##name; name = name do ...

10 years, 6 months ago (2010-06-05 01:17:13 UTC) #2

Mike Mammarella

10 years, 6 months ago (2010-06-05 01:42:37 UTC) #3

http://codereview.chromium.org/2696002/diff/1/2
File chrome/browser/password_manager/password_store_gnome.cc (right):

http://codereview.chromium.org/2696002/diff/1/2#newcode55
chrome/browser/password_manager/password_store_gnome.cc:55:
typeof(&gnome_keyring_##name) name = wrap_gnome_keyring_##name; name = name
On 2010/06/05 01:17:15, Evan Stade wrote:
> do you need name = name?
> 
> also, please insert a blank line

Yes, name = name prevents the compiler from warning about unused variables.

Blank line added.

http://codereview.chromium.org/2696002/diff/1/2#newcode125
chrome/browser/password_manager/password_store_gnome.cc:125: namespace {
On 2010/06/05 01:17:15, Evan Stade wrote:
> blank line here

Done.

http://codereview.chromium.org/2696002/diff/1/2#newcode128
chrome/browser/password_manager/password_store_gnome.cc:128: }
On 2010/06/05 01:17:15, Evan Stade wrote:
> ditto

Done.

Expand Messages | Collapse Messages