Issue 2694006: Make all TPM command functions return TPM_SUCCESS or the TPM error code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2694006: Make all TPM command functions return TPM_SUCCESS or the TPM error code. (Closed)

Created:
10 years, 6 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, Randall

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/tpm_lite.git

Visibility:
Public.

Description

Make all TPM command functions return TPM_SUCCESS or the TPM error code.

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -70 lines)			Patch
	M	src/tlcl/tlcl.h	View		1 chunk	+29 lines, -25 lines	0 comments	Download
	M	src/tlcl/tlcl.c	View		4 chunks	+25 lines, -45 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

You may be interested in a quick commit of this one---otherwise I can ask Gaurav. ...

10 years, 6 months ago (2010-06-07 22:35:20 UTC) #1

Luigi Semenzato

Normally in /usr/include/tss/tpm_error.h. We copied the ones of interest to vboot_firmware/lib/include/tss_constants.h. If you don't have ...

10 years, 6 months ago (2010-06-08 15:01:44 UTC) #3

Randall Spangler

10 years, 6 months ago (2010-06-08 16:24:53 UTC) #4

Thanks for the explanation.

Can you add a comment to that effect in tlcl.h?  Something like

/* The subset of TPM error codes relevant to verified boot (TPM_SUCCESS,
etc.) are in tss_constants.h.
 * A full list of TPM error codes are in /usr/include/tss/tpm_error.h, from
the trousers package. */

Thanks,
    Randall

On Tue, Jun 8, 2010 at 8:01 AM, Luigi Semenzato <semenzato@chromium.org>wrote:

> Normally in /usr/include/tss/tpm_error.h.  We copied the ones of
> interest to vboot_firmware/lib/include/tss_constants.h.
>
> If you don't have that header file, the fastest way to get it is
> apt-get install trousers on your host.
>
> On Mon, Jun 7, 2010 at 6:54 PM,  <rspangler@chromium.org> wrote:
> > LGTM.
> >
> > Where are the TPM error codes defined?
> >
> >
> > http://codereview.chromium.org/2694006/show
> >
>

Expand Messages | Collapse Messages