Issue 2694001: policy-utils.js: reset cert.path in onInstall after a restart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2694001: policy-utils.js: reset cert.path in onInstall after a restart (Closed)

Created:
10 years, 6 months ago by rginda

Modified:
9 years, 7 months ago

Reviewers:
Nathan Williams

CC:
chromium-os-reviews_chromium.org, stevenjb, rtc

Base URL:
ssh://git@chromiumos-git//entd.git

Visibility:
Public.

Description

policy-utils.js: reset cert.path in onInstall after a restart Now that we're remembering certs between restarts, we exposed a bug in how cert.path is set. This resulted in the certificate path being blown away on the second startup.

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -29 lines)			Patch
	M	base_policy/policy-utils.js	View		4 chunks	+28 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rginda

I'm still rebuilding in the new git world, so I haven't actually tested this yet.

10 years, 6 months ago (2010-06-04 22:05:09 UTC) #1

Nathan Williams

LGTM (after fixing the pilot error on my system where the file was ending up ...

10 years, 6 months ago (2010-06-08 22:17:35 UTC) #2

rginda

10 years, 6 months ago (2010-06-08 22:47:22 UTC) #3

On 2010/06/08 22:17:35, Nathan Williams wrote:
> LGTM (after fixing the pilot error on my system where the file was ending up
> mode 640 and thus unreadable by entd).

cool, thanks.  pushed.

Expand Messages | Collapse Messages