Issue 269083: More CopyDirectory tests and fixes...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269083: More CopyDirectory tests and fixes... (Closed)

Created:
11 years, 2 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, brettw+cc_chromium.org, John Grabowski, tim (not reviewing), Paweł Hajdan Jr., Miranda Callahan

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

More CopyDirectory tests and fixes BUG=themes stopped working on Linux and Mac TEST=unittests

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -9 lines)			Patch
M	base/file_util_posix.cc	View	1	2 chunks	+26 lines, -9 lines	0 comments	Download
M	base/file_util_unittest.cc	View	1	2 chunks	+116 lines, -0 lines	0 comments	Download
M	base/file_util_win.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lg if it works http://codereview.chromium.org/269083/diff/1/3 File base/file_util_posix.cc (right): http://codereview.chromium.org/269083/diff/1/3#newcode174 Line 174: // must be the ...

11 years, 2 months ago (2009-10-14 21:31:44 UTC) #2

vandebo (ex-Chrome)

Hmm, inconsistent try results point out an assumption in the Windows code that is now ...

11 years, 2 months ago (2009-10-15 00:02:33 UTC) #3

ok

Expand Messages | Collapse Messages