Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 269041: Implement a version of NativeMetafile for the Mac (Closed)

Created:
11 years, 2 months ago by stuartmorgan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implement a version of NativeMetafile for the Mac This is the first of series of patches to implement printing on the Mac. This API is based heavily on the Linux version; although it doesn't end up abstracting very much on the Mac, having a NativeMetafile implementation makes it easy to pass data through the existing print architecture. BUG=13158 TEST=Printing unit tests; no effect in the application yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28722

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -8 lines) Patch
M printing/native_metafile.h View 1 chunk +7 lines, -8 lines 2 comments Download
A printing/pdf_metafile_mac.h View 1 chunk +72 lines, -0 lines 0 comments Download
A printing/pdf_metafile_mac.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A printing/pdf_metafile_mac_unittest.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M printing/printing.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stuartmorgan
11 years, 2 months ago (2009-10-10 00:18:59 UTC) #1
Amanda Walker
LGTM
11 years, 2 months ago (2009-10-10 01:28:34 UTC) #2
pink (ping after 24hrs)
drive-by http://codereview.chromium.org/269041/diff/1/2 File printing/native_metafile.h (right): http://codereview.chromium.org/269041/diff/1/2#newcode33 Line 33: typedef PdfMetafile NativeMetafile; Ben's multi-platform development doc ...
11 years, 2 months ago (2009-10-12 14:43:01 UTC) #3
stuartmorgan
11 years, 2 months ago (2009-10-12 16:52:17 UTC) #4
http://codereview.chromium.org/269041/diff/1/2
File printing/native_metafile.h (right):

http://codereview.chromium.org/269041/diff/1/2#newcode33
Line 33: typedef PdfMetafile NativeMetafile;
Filed http://crbug.com/24605

Powered by Google App Engine
This is Rietveld 408576698