Issue 269039: [Mac] Add breakpad info for crashes in the target/action dispatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269039: [Mac] Add breakpad info for crashes in the target/action dispatcher. (Closed)

Created:
11 years, 2 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski, jeremy

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Add breakpad info for crashes in the target/action dispatcher. -[NSApplication sendAction:to:from:] is a central dispatcher for target-action messages sent by controls. Backtraces from here often contain only Cocoa messages, making it hard to tell where things are at when a freed target gets messaged. Add additional info like the action being requested and the tag of the sender. http://crbug.com/24460 TEST=Browser continues to work.

Patch Set 1 #

Patch Set 2 : Fix build problem with all.xcodeproj chromium_builder_dbg #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	M	chrome/browser/chrome_application_mac.mm	View	1	2 chunks	+47 lines, -0 lines	0 comments	Download
	M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

On 2009/10/12 18:07:55, John Grabowski wrote: > LGTM http://crash/reportdetail?reportid=dae2a0c411e91f33 > sendaction: BrowserWindowController tag 0 sending ...

11 years, 2 months ago (2009-10-12 19:50:49 UTC) #4

Scott Hess - ex-Googler

On 2009/10/12 18:07:55, John Grabowski wrote: > LGTM John, Broke the build! Undefined symbols building ...

11 years, 2 months ago (2009-10-12 22:46:26 UTC) #5

John Grabowski

11 years, 2 months ago (2009-10-12 23:00:47 UTC) #6

On 2009/10/12 22:46:26, shess wrote:
> On 2009/10/12 18:07:55, John Grabowski wrote:
> > LGTM
> 
> John,
> 
> Broke the build!  Undefined symbols building ui_tests.  Of course it passed
the
> trybots.  This fixes it.  WDYT?

LGTM since consistent with previous patterns.
But in the big picture this sucks.
I think we should add this file to the buyndle of all test files compiled into
all unit tests.

Expand Messages | Collapse Messages